chore: update whisper.cpp submodule to v1.8.2, build for all cpu variants#145
Closed
candrews wants to merge 2 commits intoabsadiki:mainfrom
Closed
chore: update whisper.cpp submodule to v1.8.2, build for all cpu variants#145candrews wants to merge 2 commits intoabsadiki:mainfrom
candrews wants to merge 2 commits intoabsadiki:mainfrom
Conversation
The best variant will be selected at run time resulting in better performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update whisper.cpp from 1.7.6 to 1.8.2: https://github.com/ggml-org/whisper.cpp/releases
There are a number of useful improvements in these releases, including some significant performance gains.
Disable 32 bit Windows because whisper.cpp doesn't currently build for it, see ggml-org/whisper.cpp#3543
The best variant will be selected at run time resulting in better performance.
This PR is an alternative to #144 - it offers the advantage of building for all cpu variants allowing the best one to be automatically selected at runtime resulting in improved performance. However, targeting 32 bit Windows must be disabled. I don't know if anyone uses or cares about 32 bit Windows, so that probably is not problematic.